Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for negation in search operations #819

Merged
merged 1 commit into from Mar 24, 2018

Conversation

splatch
Copy link
Contributor

@splatch splatch commented Jan 9, 2018

This solves issue #815 by flipping filter criteria from equals to not equals.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 72.508% when pulling 66b6149 on splatch:issue-815 into d375977 on jamesagnew:master.

@splatch
Copy link
Contributor Author

splatch commented Jan 23, 2018

@jamesagnew Any chances for processing this PR anytime soon?

@jamesagnew
Copy link
Collaborator

Hi @splatch, yup- I'm planning a big review cycle right after the next FHIR connectathon (this weekend) to get everything caught up. Things have been busy in the leadup to that with preparations.

One request- could you add a unit test which demonstrates the issue that this is solving?

@jamesagnew jamesagnew merged commit 4f519e0 into hapifhir:master Mar 24, 2018
jamesagnew added a commit that referenced this pull request Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants